Refactoring, Linting and additional tests #1397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackivanov
force-pushed
the
fix-213
branch
2 times, most recently
from
fcd3f7c
to
9661133
Compare
This comment has been minimized.
This comment has been minimized.
|
Repeat installation on Vultr was successful, but there was one warning. |
|
Seems like a bug, but it doesn't affect us in any ways. Not sure if we can avoid this warning without doing some hacks in the code |
5 tasks
andreimc
added a commit
to tunnelhero/algo
that referenced
this pull request
Apr 29, 2019
* upstream/master: (22 commits) Automatically create cloud firewall rules for installs onto Vultr (trailofbits#1400) Refactoring, Linting and additional tests (trailofbits#1397) Update Linux WireGuard client instructions (trailofbits#1407) Update cloud-vultr.md (trailofbits#1406) Update openssl.yml (trailofbits#1403) Update deploy-from-script-or-cloud-init-to-localhost.md Update README.md (trailofbits#1380) Update Adblock lists (trailofbits#1394) fix: get public IP from default interface (trailofbits#1396) Move `Delete the CA key` task to the appropriate role (trailofbits#1393) Update deploy-from-script-or-cloud-init-to-localhost.md Consolidate firewall documentation (trailofbits#1386) Fix 963 again (trailofbits#1379) Refactoring to support roles inclusion (trailofbits#1365) Update DNS filtering advice in FAQ (trailofbits#1389) Use VULTR_API_CONFIG variable if set (trailofbits#1374) IPv6 range to AllowedIPs only when ipv6_support (trailofbits#1388) Update ubuntu.yml (trailofbits#1383) Script to support cloud-init and local easy deploy (trailofbits#1366) Update 10-algo-lo100.network.j2 (trailofbits#1369) ...
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
openssl_publickeymodule - openssl_publickey is broken in python3 ansible/ansible#54190. Now, algo asks to upgrade the requirements if ansible version is lower than required. Fixes Upgrade to Ansible 2.5.15 or later #1398 (CVE-2019-3828)How Has This Been Tested?
We still have to do a few deployments to the providers we support to be sure it works as expected:
Types of changes
Checklist: