Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md dependencies for ubuntu #14634

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

peyloride
Copy link
Contributor

@peyloride peyloride commented Jul 29, 2023

file and lookup are part of the ubuntu most of the time but in some cases it was missing therefore ansible fails.

Description

file and lookup are being used in playbook here. It was failing and indicating that file is not exists but it wasn't telling you that it's because these commands are not working. So it was kinda hard to find the exact cause.

Motivation and Context

In most cases this won't change anything but for example I was trying to deploy algo on Oracle Free Tier instance with a minimal ubuntu 22.04 build. These packages are not installed by default on that image.

How Has This Been Tested?

Tested on my instance, after installing these algo works as expected.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

`file` and `lookup` are part of the ubuntu most of the time but in some cases it was missing therefore ansible fails.
@CLAassistant
Copy link

CLAassistant commented Jul 29, 2023

CLA assistant check
All committers have signed the CLA.

@jackivanov
Copy link
Collaborator

@peyloride If you could sing the CLA please

@peyloride
Copy link
Contributor Author

@peyloride If you could sing the CLA please

Sorry, I miss the notification. Signed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants