Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ubuntu 20.04 support #1782

Merged
merged 3 commits into from
May 10, 2020
Merged

Ubuntu 20.04 support #1782

merged 3 commits into from
May 10, 2020

Conversation

jackivanov
Copy link
Collaborator

@jackivanov jackivanov commented Apr 25, 2020 •
edited
Loading

Description

Motivation and Context

How Has This Been Tested?

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jackivanov jackivanov marked this pull request as ready for review April 25, 2020 18:02
@davidemyers
Copy link
Contributor

Don't forget the prompt in input.yml.

@jackivanov
Copy link
Collaborator Author

@davidemyers Ok, seems done, can you take a look?

@davidemyers
Copy link
Contributor

Deployed to DigitalOcean and confirmed that the WireGuard module bundled with the kernel is being used and dkms is no longer installed.

In my recent PR in roles/strongswan/defaults/main.yml I tested the OS version with ansible_distribution_major_version|int > 19. In this PR you use the more elegant version('20.04', '<'). Do you want to change what I did previously to version('20.04', '>=')?

@jackivanov
Copy link
Collaborator Author

@davidemyers good catch, thanks, added

@jackivanov jackivanov merged commit c14ff0d into master May 10, 2020
everglowz pushed a commit to everglowz/algo that referenced this pull request May 23, 2020
@jackivanov @everglowz
Ubuntu 20.04 support (trailofbits#1782)
e2dcc2e 
* ubuntu 20.04 support

* purge snapd for 20.04

* strongswan-starter fix
davedittrich pushed a commit to davedittrich/algo that referenced this pull request Sep 25, 2020
@jackivanov @davedittrich
Ubuntu 20.04 support (trailofbits#1782)
8a00299 
* ubuntu 20.04 support

* purge snapd for 20.04

* strongswan-starter fix
foodneutrino pushed a commit to foodneutrino/algo that referenced this pull request Sep 19, 2021
@jackivanov @foodneutrino
Ubuntu 20.04 support (trailofbits#1782)
4c290d2 
* ubuntu 20.04 support

* purge snapd for 20.04

* strongswan-starter fix
@dguido dguido deleted the feature/ubuntu20.04 branch January 8, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jackivanov @davidemyers