skip virtualenv check if already activated #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the user to choose their virtualenv method, e.g. [Pipenv](https://docs.pipenv.org/).
|
It doesn't look like either CI failure is due to this change. |
|
Thanks! |
eyecat
pushed a commit
to eyecat/algo
that referenced
this pull request
Oct 23, 2018
This allows the user to choose their virtualenv method, e.g. [Pipenv](https://docs.pipenv.org/).
faf0
pushed a commit
to faf0/algo
that referenced
this pull request
Dec 13, 2018
This allows the user to choose their virtualenv method, e.g. [Pipenv](https://docs.pipenv.org/).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the user to choose their virtualenv method, e.g. Pipenv while still being friendly for those not familiar with virtual environments.
Pipenv (and other virtual environment management tools) may create the environment somewhere other than inside the project directory.
Note that this solution may be insufficient if the project ever uses Python 3 and supports venv; we may need to use a Python-based solution then, e.g. https://stackoverflow.com/a/42580137