Native fixes, and friends #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ESultanik
approved these changes
Jul 15, 2021
| ) | ||
| for dep in package["dependencies"] | ||
| ], | ||
| dependencies=dependencies.values(), |
There was a problem hiding this comment.
I think I originally created copies of the dependency objects to ensure that modifications didn't affect the original, but this should be fine (and faster).
it_depends/cargo.py
Outdated
| @@ -102,42 +112,39 @@ def resolve_from_source( | |||
| if cache is not None: | |||
| cache.add(package) | |||
| for dep in package.dependencies: | |||
| cache.set_resolved(dep) | |||
| if not cache.was_resolved(dep): | |||
There was a problem hiding this comment.
I think cache.set_resolved first checks if it was already resolved, so this might be slightly slower, but it's fine to keep it this way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a mostly a refactor. Merging some fixes with dev/native-updates.
Cargo single resolve fix:
Determinism related problem. It used to chose among a few optional dependencies. Now mutiple optional deps are collapsed into one dependency. Ex llvm-ir -> llvm-sys. Note that crates.io fail to show all optionals deps
Test fixes (Examples of each type of project supported #14)
Initial attempt to Breath-First dep search (needs propper algo). (Optional max depth for dependency resolution #16)