Add basic Podman support #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, with Podman installed in rootless mode, it-depends crashes telling me I need to `apt-get install` docker. Add some basic conditional logic to check for a Podman rootless socket and use it if present. If not found, _try_podman_socket() returns `None`, the previous value supplied by it-depends for base_url. This should make it backwards-compatible with existing it-depends users.
|
|
|
Sorry for the delay here! I'll review this today. |
woodruffw
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, with Podman installed in rootless mode,
it-dependscrashes telling me I need toapt-get install docker.Add some basic conditional logic to check for a Podman rootless socket and use it if present. If not found,
_try_podman_socket()returnsNone, the previous value supplied byit-dependsforbase_url. This should make it backwards-compatible with existing it-depends users.Resolves #63.
Happy to extend with docs or other changes as needed.