Aarch64

[nkaretnikov]

This change is 

[nkaretnikov]

My Aarch64 work will be happening here. Currently this just includes code by @disconnect3d (with minor changes and updated for current master) and is completely untested. Things might be changing a lot while this is still in development, but feel free to review and comment if you feel like it.

[nkaretnikov]

CC @yan (just in case)

[nkaretnikov]

Fixed codeclimate issues in all files affected by this branch, not just my changes, including ignored paths.
If it's too much, I can fix only those introduced by me, but the above was easier to track locally.

There are some things left, but:

• they are usually ignored ("Consider refactoring"), if I understood @ehennenfent correctly
• fixes would lead to even uglier (IMO) code ("Visually indented line with same indent as next logical line")
• or those issues are just hard to fix ("Consider simplifying this complex logical expression").

Maybe it's worth ignoring some issues in the config: https://pep8.readthedocs.io/en/latest/intro.html#configuration

(Note that the number of issues is different below from what GitHub reports, but that's because I provide paths myself.)

% codeclimate analyze $(git diff --name-only master)
Starting analysis
Running structure: Done!
Running duplication: Done!
Running pep8: Done!

== manticore/native/cpu/aarch64.py (8 issues) ==
271-5318: `Aarch64Cpu` has 170 functions (exceeds 35 allowed). Consider refactoring. [structure]
302-331: Consider simplifying this complex logical expression. [structure]
305: Visually indented line with same indent as next logical line [pep8]
838: Visually indented line with same indent as next logical line [pep8]
1220-1234: Consider simplifying this complex logical expression. [structure]
3032-3060: Consider simplifying this complex logical expression. [structure]
3035: Visually indented line with same indent as next logical line [pep8]
4680-4694: Consider simplifying this complex logical expression. [structure]

== manticore/platforms/linux.py (1 issue) ==
873-1071: Function `load` has a Cognitive Complexity of 74 (exceeds 40 allowed). Consider refactoring. [structure]

== tests/native/test_aarch64cpu.py (2 issues) ==
1-14120: File `test_aarch64cpu.py` has 11416 lines of code (exceeds 9000 allowed). Consider refactoring. [structure]
172-14027: `Aarch64Instructions` has 1,412 functions (exceeds 35 allowed). Consider refactoring. [structure]

== tests/native/test_armv7unicorn.py (1 issue) ==
96-1328: `Armv7UnicornInstructions` has 161 functions (exceeds 35 allowed). Consider refactoring. [structure]

Analysis complete! Found 12 issues.

[nkaretnikov]

Just to demonstrate accepted fixes (that I know of), I'll let you judge:

# 3: Visually indented line with same indent as next logical line [pep8]
if (True or
    False):
    pass

# Accepted.
if (
    True or
    False
):
    pass

# Accepted.
if (True or
   False):
    pass

# Accepted.
if (True or
        False):
    pass

[nkaretnikov]

Squashed and rebased on master:
https://github.com/nkaretnikov/manticore/commits/aarch64-squash-rebase

Verified that there are no major differences by diffing my changes on this branch to my changes on the new one.

Will be splitting the new branch into smaller PRs next.

[nkaretnikov]

@ehennenfent Split nkaretnikov/aarch64-squash-rebase (this PR squashed and rebased on master) into multiple PRs:

• aarch64: add everything except instructions #1418
• aarch64: add instructions #1419
• aarch64: add instruction tests: A-B #1420
• aarch64: add instruction tests: C-L #1421
• aarch64: add instruction tests: M-S #1422
• aarch64: add instruction tests: T-U #1423

The idea here is to merge them in this particular order as each PR builds on the previous one. If git can't deal with commits on a feature branch that are already present on master, one will have to cherry-pick or rebase first.

After applying all of them, there should be no changes against nkaretnikov/aarch64-squash-rebase.

The advantage of this split method is that it doesn't introduce or remove any code in-between.
The disadvantage is that you'll need to merge some commits to master without tests. But you can always test locally first, and the tests will end up in master anyway when the last commit is merged. So this shouldn't be a problem.

[nkaretnikov]

I'm closing this one to avoid confusion.