Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More informative errors for unimplemented EVM features #1387

Merged
merged 3 commits into from
Mar 14, 2019
Merged

More informative errors for unimplemented EVM features #1387

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a0567bd
Report the transaction type that is not yet supported
ESultanik Mar 12, 2019
7abf9df
Added a more informative error about the `STATICCALL` opcode (#1168)
ESultanik Mar 12, 2019
e7e1cca
Reminder for when #1168 is addressed
ESultanik Mar 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion manticore/platforms/evm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2532,7 +2532,11 @@ def _process_pending_transaction(self):
sort, address, price, data, caller, value, gas = self._pending_transaction

if sort not in {'CALL', 'CREATE', 'DELEGATECALL', 'CALLCODE'}:
raise EVMException('Type of transaction not supported')
if sort == 'STATICCALL':
# TODO: Remove this once Issue #1168 is resolved
raise EVMException(f"The STATICCALL opcode is not yet supported; see https://github.com/trailofbits/manticore/issues/1168")
else:
raise EVMException(f"Transaction type '{sort}' not supported")

if self.depth > 0:
assert price is None, "Price should not be used in internal transactions"
Expand Down