Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for proc/self/maps #1639
Added support for proc/self/maps #1639
Changes from 4 commits
b478aef
159e701
778aa19
166ea87
4e25b09
c566877
8ece48f
7040db1
9833f23
9e82b99
db3b4a6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For classes that have a superclass, it's generally best to start off the
__getstate__
method withstate = super().__getstate__()
and then updatestate
from thereThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As with
__getstate__
,__setstate__
should typically start or end withsuper().__setstate__(state)
as well. Looks like most of this method is duplicated fromFile.__setstate__
, so you can probably cut out a lot of it, right? Unless there's some other functionality I'm missing.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No it's essentially the same. Originally I had the .name property returning '/proc/self/maps', in which case I would've needed to modify
__getstate__
and__setstate__
, but I realized that probably wasn't necessary. It's probably best to just remove these and rely on the superclass.