Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a syscall implementation for llseek #1640

Merged
merged 16 commits into from
Mar 30, 2020
Merged

Add a syscall implementation for llseek #1640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
df0456b
Add an implementation of sys_llseek for Linux
Mar 26, 2020
aedb842
Reformat a couple funny string literals
Mar 26, 2020
c0983dc
Add a docstring for `sys_llseek`
Mar 26, 2020
98a65d2
Fix a broken log format string
Mar 27, 2020
5f3bc51
Improve logging & exception messages in linux platform
Mar 27, 2020
cb3a924
Update docstring for sys_lseek
Mar 27, 2020
ee77f23
Remove redundant space in mmap mode strings
Mar 27, 2020
99cd6ba
Clean up temp files after linux platform tests
Mar 27, 2020
cdbc3e4
Add some tests for the `sys_lseek`
Mar 27, 2020
2b3a8f5
blacken tests/native/test_syscalls.py
Mar 27, 2020
7b6f3ae
Fix implementation of sys_llseek; expand & refine tests
Mar 27, 2020
13690ad
blacken manticore/platforms/linux.py
Mar 27, 2020
bd28600
Add some type signatures
Mar 30, 2020
779276b
Fix type signatures; add more signatures
Mar 30, 2020
238b6c5
Fix a bad variable reference
Mar 30, 2020
bca0ff2
More type signatures; fix typing issues with linux `sys_write()`
Mar 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion manticore/native/cpu/abstractcpu.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -726,7 +726,7 @@ def read_int(self, where, size=None, force=False):
self._publish("did_read_memory", where, value, size)
return value

def write_bytes(self, where, data, force=False):
def write_bytes(self, where: int, data, force: bool = False) -> None:
"""
Write a concrete or symbolic (or mixed) buffer to memory

Expand Down
7 changes: 4 additions & 3 deletions manticore/native/cpu/cpufactory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
I386CdeclAbi,
SystemVAbi,
)
from .abstractcpu import Abi, Cpu, SyscallAbi


class CpuFactory:
Expand All @@ -28,20 +29,20 @@ class CpuFactory:
}

@staticmethod
def get_cpu(mem, machine):
def get_cpu(mem, machine: str) -> Cpu:
cpu = CpuFactory._cpus[machine](mem)
mem.cpu = cpu
return cpu

@staticmethod
def get_function_abi(cpu, os, machine):
def get_function_abi(cpu: Cpu, os: str, machine: str) -> Abi:
if os != "linux" or machine not in CpuFactory._linux_abis:
raise NotImplementedError(f"OS and machine combination not supported: {os}/{machine}")

return CpuFactory._linux_abis[machine](cpu)

@staticmethod
def get_syscall_abi(cpu, os, machine):
def get_syscall_abi(cpu: Cpu, os: str, machine: str) -> SyscallAbi:
if os != "linux" or machine not in CpuFactory._linux_syscalls_abis:
raise NotImplementedError(f"OS and machine combination not supported: {os}/{machine}")

Expand Down
Loading