Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 2 problems in Linux sys_open support & add type hints #1657

Merged
merged 11 commits into from
Apr 8, 2020

Commits on Apr 6, 2020

  1. Add type hints to some Linux syscalls

    Brad Larsen committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    404e703 View commit details
    Browse the repository at this point in the history
  2. Fix a type error & add a type hint in Linux sys_open

    Brad Larsen committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    db04f91 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    42e52f5 View commit details
    Browse the repository at this point in the history
  4. Add a test case based on the fileio example

    Note, The `fileio_linux_amd64` test binary was manually copied from the
    examples directory and added to Git.  Maybe one day we will come up with
    a more principled mechanism for this.
    
    Also note, this test case currently fails, even with the `sys_open` type
    fixes.  Multiple errors are revealed by this test case.
    Brad Larsen committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    072ef24 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2020

  1. Add a type hint

    Brad Larsen committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    9c81b69 View commit details
    Browse the repository at this point in the history
  2. Add type hints to manticore workspace code

    Brad Larsen committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    ae3b1d8 View commit details
    Browse the repository at this point in the history
  3. Make an optional parameter non-optional

    This function never seems to be used without specifying the formerly
    optional value.
    Brad Larsen committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    4c8e03a View commit details
    Browse the repository at this point in the history
  4. Fix choice of abbreviation in comments

    Brad Larsen committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    328cdec View commit details
    Browse the repository at this point in the history
  5. Allow keys with / in them in FilesystemStore.

    This is an expedient fix -- a more proper fix would nail down the API of
    which characters are allowed in keys, maximum length etc, at the level
    of the `Store` class.
    Brad Larsen committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    8822ab2 View commit details
    Browse the repository at this point in the history
  6. Have fileio exit with 0 on incorrect usage

    Our GitHub CI has one step where it builds each of the example programs,
    and then attempts to run them with no arguments and no standard input,
    checking that they exit with code 0.  Rather than rework this approach
    to support more general invocation patterns for example programs, it's
    easier to change the `fileio` example I added.
    Brad Larsen committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    15e7b81 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2020

  1. Blacken manticore/core/workspace.py

    Brad Larsen committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    f59968f View commit details
    Browse the repository at this point in the history