Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable core __get_related logic #1674

Merged
merged 1 commit into from
Apr 24, 2020
Merged

Disable core __get_related logic #1674

merged 1 commit into from
Apr 24, 2020

Commits on Apr 20, 2020

  1. Disable core __get_related logic 

    There is a flaw in how __get_related works: when called on certain
unsatisfiable sets, it can return a satisfiable one. The flaw arises when:
  * self consists of a single constraint C
  * C is the value of the related_to parameter
  * C contains no variables
  * C is unsatisfiable
Since C contains no variables, it is not considered "related to" itself and is thrown out
by __get_related. Since C was the sole element of self, __get_related returns the empty
set. Thus, __get_related was called on an unsatisfiable set, {C}, but it returned a
satisfiable one, {}.
    @smoelius
    smoelius committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    fcfd1a1 View commit details
    Browse the repository at this point in the history