Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert plugin list to dict #1781

Merged
merged 3 commits into from
Aug 14, 2020
Merged

Convert plugin list to dict #1781

merged 3 commits into from
Aug 14, 2020

Conversation

ehennenfent
Copy link
Contributor

@ehennenfent ehennenfent commented Jul 30, 2020 •
edited
Loading

Replaces the plugins list on the ManticoreBase object with a dict, keyed with a unique name derived from the plugin's class and ID.

@ehennenfent ehennenfent added this to In progress in Manticore Aug 4, 2020
@ehennenfent ehennenfent mentioned this pull request Aug 10, 2020
Merged
3 tasks
@ehennenfent ehennenfent marked this pull request as ready for review August 13, 2020 18:35
@ehennenfent ehennenfent moved this from In progress to Review in progress in Manticore Aug 13, 2020
feliam
feliam approved these changes Aug 13, 2020
View reviewed changes
Copy link
Contributor

@feliam feliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great!

Manticore automation moved this from Review in progress to Reviewer approved Aug 13, 2020
@ehennenfent ehennenfent merged commit 402de84 into master Aug 14, 2020
Manticore automation moved this from Reviewer approved to Done Aug 14, 2020
@ehennenfent ehennenfent deleted the dev-plugin-dict branch August 14, 2020 21:50
@ehennenfent ehennenfent added this to the Manticore 0.3.5 milestone Sep 3, 2020
ekilmer added a commit that referenced this pull request Sep 28, 2020
@ekilmer
Merge branch 'master' into capstone-5-dev
3e646f7 
* master:
  Change types.FunctionType=<class 'function'> (#1803)
  Fix test regressions (#1804)
  State Introspection API (#1775)
  Fix EVM account existence checks for selfdestruct and call (#1801)
  Add partial implementation of sendto syscall (#1791)
  crytic-compile: use latest release (#1795)
  Update gas metering for calls to empty accounts (#1774)
  Fix BitVec with symbolic offset and fix TranslatorSmtlib.unique thread safety (#1792)
  Fix Coveralls for external PRs (#1794)
  Convert plugin list to dict (#1781)
  Symbolic-length reads from symbolic sockets (#1786)
  Removing Thread unsafe global caching (#1788)
  Add Manticore native State-specific hooks (#1777)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feliam feliam feliam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Manticore
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ehennenfent @feliam