Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install pinned version of truffle to fix CI #2467

Merged
merged 1 commit into from
Jul 13, 2021
Merged

Install pinned version of truffle to fix CI #2467

merged 1 commit into from
Jul 13, 2021

Conversation

ekilmer
Copy link
Contributor

@ekilmer ekilmer commented Jul 9, 2021

This pinned version should be reverted when crytic/crytic-compile#199 is fixed.

@ekilmer ekilmer marked this pull request as ready for review July 9, 2021 13:54
@ekilmer ekilmer marked this pull request as draft July 9, 2021 15:38
@ehennenfent ehennenfent added this to In progress in Manticore Jul 13, 2021
@ekilmer ekilmer marked this pull request as ready for review July 13, 2021 16:05
@ekilmer ekilmer requested a review from ehennenfent July 13, 2021 16:07
Copy link
Contributor

@ehennenfent ehennenfent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go ahead and merge. Using a pinned version of truffle isn't a good long-term solution, but until an updated release of crytic-compile is available on PyPI, it's the best way to unblock our development. We should revisit this at future weekly meetings and revert once all the upstream issues are resolved. Thanks for looking into this!

Manticore automation moved this from In progress to Reviewer approved Jul 13, 2021
@ehennenfent ehennenfent merged commit 378f8e8 into master Jul 13, 2021
@ehennenfent ehennenfent deleted the fix-ci branch July 13, 2021 18:19
Manticore automation moved this from Reviewer approved to Done Jul 13, 2021
ekilmer added a commit that referenced this pull request Jul 15, 2021
* master:
  Install pinned version of truffle to fix CI (#2467)
  Use fixed owner and attacker accounts in multi_tx_analysis (#2464)
  Manticore 0.3.6 (#2456)
  Fix IntrospectionAPIPlugin Name (#2459)
  Portfolio of parallel solvers (#2420)
  Replace Quick mode with Thorough mode (#2457)
  Fix incorrect comparison for symbolic file wildcards (#2454)
  Reduce the number of calls to the SMT solver in EVM (#2411)
  Fixes to Unicorn emulation - start/stop/resume (#1796)
  Add support for multiple compilation units (#2444)
  Basic solver stats (#2415)
ekilmer added a commit that referenced this pull request Jul 27, 2021
* master: (35 commits)
  Track last_pc in StateDescriptors (#2471)
  Expose Result Register for Native CPU (#2470)
  Install pinned version of truffle to fix CI (#2467)
  Use fixed owner and attacker accounts in multi_tx_analysis (#2464)
  Manticore 0.3.6 (#2456)
  Fix IntrospectionAPIPlugin Name (#2459)
  Portfolio of parallel solvers (#2420)
  Replace Quick mode with Thorough mode (#2457)
  Fix incorrect comparison for symbolic file wildcards (#2454)
  Reduce the number of calls to the SMT solver in EVM (#2411)
  Fixes to Unicorn emulation - start/stop/resume (#1796)
  Add support for multiple compilation units (#2444)
  Basic solver stats (#2415)
  Fix the generation of EVM tests (#2426)
  Disabled EVM events in testcases by default (#2417)
  added proper timeouts for cvc4 and boolector (#2418)
  Removed use of global solver from Native Memory (#2414)
  Support to use boolector as the SMT solver (#2410)
  Update CI and suggest to use pip3 instead of pip (#2409)
  Expressions use keyword-only arguments for init (#2395)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Manticore
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants