Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add syscall implementation for sys_newfstatat #2545

Merged
merged 2 commits into from
May 16, 2022
Merged

Add syscall implementation for sys_newfstatat #2545

merged 2 commits into from
May 16, 2022

Conversation

lordidiot
Copy link
Contributor

Almost correct concrete implementation for sys_newfstatat. I believe it should be accurate enough for most common usages.

Currently lacking full support for some of the flags the syscall supports

  • AT_STATX_SYNC_AS_STAT
  • AT_STATX_FORCE_SYNC
  • AT_STATX_DONT_SYNC

ekilmer
ekilmer approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@ekilmer ekilmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, but I want to wait to merge it until the UnicornResumeTest.test_integration_resume test works on Ubuntu 22.04 (with Capstone updates), which seems to also require implementation of rseq syscall and possibly sys_*_robust_list syscalls.

@ekilmer ekilmer merged commit f8ad2df into trailofbits:master May 16, 2022
ekilmer added a commit that referenced this pull request May 16, 2022
@ekilmer
Merge branch 'master' into capstone-5-dev
7a45dbc 
* master:
  Add syscall implementation for `sys_newfstatat` (#2545)
  Fix newstat and newfstat (#2544)
ekilmer added a commit that referenced this pull request May 23, 2022
@ekilmer
Merge branch 'master' into chess
9c3f447 
* master:
  Capstone 5 updates (5.0.0rc2) (#1701)
  Add syscall implementation for `sys_newfstatat` (#2545)
  Fix newstat and newfstat (#2544)
ekilmer added a commit that referenced this pull request May 23, 2022
@ekilmer
Merge branch 'chess' into fix-latest-glibc
73fa4e3 
* chess:
  Capstone 5 updates (5.0.0rc2) (#1701)
  Add syscall implementation for `sys_newfstatat` (#2545)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekilmer ekilmer ekilmer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lordidiot @ekilmer