Add psubq instruction (x86)
#2553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Boyan-MILANOV
approved these changes
May 25, 2022
manticore/native/cpu/x86.py
Outdated
| for i in reversed(range(0, dest.size, 64)): | ||
| a = Operators.EXTRACT(value_a, i, 64) | ||
| b = Operators.EXTRACT(value_b, i, 64) | ||
| result.append((a - b) & 0xFFFFFFFFFFFFFFFF) |
There was a problem hiding this comment.
We are subtracting on 64 bits already so I don't think masking with 0xffffffffffffffff is necessary?
There was a problem hiding this comment.
Ok! I thought it should be used to explicitly mask any negative results, but I think this is also done in CONCAT so I will remove it.
There was a problem hiding this comment.
Yeah bitvector arithmetic will round up to 64 bits anyway.
ekilmer
added a commit
that referenced
this pull request
May 25, 2022
* master: Add `psubq` instruction (x86) (#2553)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
psubqx86 instruction. Implementation very similar topsubb.