fixed header collisions when windows.h included

[stevemk14ebr]

On windows if winnt.h is already included then all the defs in nt-headers collide and give > 100 errors. Here are the minimal windows changes needed to fix this. This will probably break linux, so probably best to do an ifdef on the platform being compiled. This was how i chose to fix it because i already use windows.h, there's probably a better option but that is up to you all.

Your build docs for windows should also not us DCMAKE flag instead use config

build all from command line:

cmake -G "Visual Studio 15 2017"
cmake --build . // for debug
cmake --build . --config Release // for release

if building from .sln then just use -G and set the config mode using visual studio gui.

[CLAassistant]

All committers have signed the CLA.

[alessandrogario]

Hey @stevemk14ebr!
Thanks for signing the CLA! Before we merge though we have to have a look at the CI errors that Travis found

[ghost]

@stevemk14ebr, all the constants that appear to be colliding are actually a part of the peparse namespace.

Since Linux doesn't have the Windows.h header file, pe-parse has to explicitly declare them somewhere.

Would you happen have a using namespace peparse; declared in your project? Removing that would likely fix the issue.

[woodruffw]

Closing per @jacwil's advice.

[woodruffw]

I think I closed this prematurely -- namespaces won't help with the macros introduced by Windows.h, and it looks like IMAGE_FILE_* are some of those macros.

[woodruffw]

Actually, closing since we don't want this approach. Will open a tracking issue.