Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

polytracker: fixes for the linter #6504

Merged
merged 3 commits into from
Nov 10, 2022
Merged

polytracker: fixes for the linter #6504

merged 3 commits into from
Nov 10, 2022

Conversation

kaoudis
Copy link
Collaborator

@kaoudis kaoudis commented Nov 9, 2022

  • pulls out @hbrodin's mypy lint fixes into a separate PR so they can be merged soonest since the linters fail on the plain main branch right now
  • experimented with additional changes to make the flake8 errors I was also seeing on init.py go away, but oddly flake8 and mypy seem to be nondeterministically fighting over what is "ok" here. Perhaps flake8's not finding implicit dependencies on things imported in init correctly?

@kaoudis kaoudis requested a review from hbrodin November 9, 2022 21:00
ESultanik
ESultanik approved these changes Nov 9, 2022
View reviewed changes
Copy link
Collaborator

@ESultanik ESultanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me, but I'll defer to @hbrodin since he's more familiar with these changes.

@kaoudis
Copy link
Collaborator Author

kaoudis commented Nov 9, 2022

Thanks @ESultanik !

hbrodin
hbrodin approved these changes Nov 10, 2022
View reviewed changes
Copy link
Collaborator

@hbrodin hbrodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hbrodin hbrodin merged commit 55b0add into master Nov 10, 2022
@hbrodin hbrodin deleted the kaoudis/python-linter-fixes branch November 10, 2022 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ESultanik ESultanik ESultanik approved these changes

@hbrodin hbrodin hbrodin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kaoudis @ESultanik @hbrodin