Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit output format for mitigation presence #66

Closed
woodruffw opened this issue May 1, 2020 · 7 comments · Fixed by #68
Closed

Revisit output format for mitigation presence #66

woodruffw opened this issue May 1, 2020 · 7 comments · Fixed by #68
Assignees
Labels
enhancement New feature or request

Comments

@woodruffw
Copy link
Member

We currently model the presence of mitigations as true or false, making a partially arbitrary choice when a mitigation doesn't apply (e.g. ASLR on .NET, SafeSEH on x86_64). Instead, we should model presence as true, false, or "N/A".

@woodruffw
Copy link
Member Author

More generally, we should remodel the output away from:

{
  "mitigation": bool
}

to:

{
  "mitigation": {
    "present": bool | "N/A",
    "flag": "/WHATEVER",
    "description": "whatever"
  }
]

@haxmeadroom
Copy link
Contributor

Yeah, I was also wanting more granularity than true or false. Might need unimplemented or other conditions besides N/A (for WinVerifyTrust for example).

@haxmeadroom
Copy link
Contributor

Maybe each flag should have true/false/other, and a text field to describe the details?

@woodruffw
Copy link
Member Author

Maybe each flag should have true/false/other, and a text field to describe the details?

That sounds good to me!

@haxmeadroom
Copy link
Contributor

We could also put a @disconnect3d 's --info there, or maybe that makes sense for another completely new field.

@woodruffw
Copy link
Member Author

New field makes sense to me -- I was thinking description or similar.

@woodruffw
Copy link
Member Author

I'm going to take a stab at this now, since I'm waiting on builds 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants