Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to set options for barman connectivity #8

Merged
merged 1 commit into from
May 3, 2019

Conversation

chtitux
Copy link
Contributor

@chtitux chtitux commented May 2, 2019

  • Allow to pass arbitrary options
  • Build the URL in a dedicated template
  • Allow to specify path prefix for barman files
  • Add documentation in README.md

Copy link

@paulrbr-fl paulrbr-fl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. I left a comment about the style of building variables. WDYT?

tasks/postgres-standby-barman.yml Outdated Show resolved Hide resolved
templates/standby-clone.sh.j2 Show resolved Hide resolved
- Allow to pass arbitrary options
- Build the URL in a dedicated step
- Allow to specify path prefix for barman files
- Add documentation in [README.md](README.md)
@paulrbr-fl
Copy link

purfect! That's much more readable! Thanks @chtitux

@paulRbr paulRbr merged commit b9038ad into trainline-eu:master May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants