New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add normalised code column #788
Add normalised code column #788
Conversation
…d and have correct format
# Conflicts: # stations.csv
# Conflicts: # stations.csv
In your PR the normalized code look like: urn:trainline:public:nloc:eu18 I think the normalized code should not include eu in their name to be futur proof if one day we expand outside the European continent. |
Starting the current normalised identifiers in this file with euXX does not mean that all normalised location identifiers will have the same format. (For example: normalised location identifiers from atoc, which will be going against the GB stations in this file, will be of the form urn:trainline:public:nloc:atocXXX). |
(conflicting on csv) re-apply normalised_code column using csvXXX as identifiers
Conflict on stations.csv Update Readme file with new column
This PR builds on #786, which should be merged first. (or ignored if this PR is approved as a single item)
Using the new same_as values to determine the correct value to add for a new normalised_code column.
Currently the column is only set for non-GB locations. The GB locations will be updated separately at a later date.
I have added a unit test to ensure that all rows have the correct value set in the new column.