Skip to content

Commit

Permalink
Try to fix the github CI to install bigdecimal for the jruby 9.1
Browse files Browse the repository at this point in the history
round.
  • Loading branch information
billdueber committed Feb 6, 2024
1 parent 02985cc commit 9a0d1b9
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/ruby.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,10 @@ jobs:
# Still seems to be an issue in jruby-9.1, but not 9.2
# https://github.community/t/conditional-setting-of-env-variables-in-gh-actions/179650

- name: Set up bigdecimal for jruby 9.1
run: gem install bigdecimal -v '1.4.4' --source 'https://rubygems.org/'
if: ${{ matrix.ruby == 'jruby-9.1' }}

- name: Install dependencies
run: bundle install --jobs 4 --retry 3
- name: Run tests
Expand Down
5 changes: 0 additions & 5 deletions traject.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,4 @@ Gem::Specification.new do |spec|
spec.add_development_dependency "rake"
spec.add_development_dependency "minitest"
spec.add_development_dependency "rspec-mocks", '~> 3.4'

# Old versions of jruby need to require bigdecimal
if RUBY_VERSION =~ /jruby/i
spec.add_dependency 'bigdecimal', '= 1.4.4'
end
end

0 comments on commit 9a0d1b9

Please sign in to comment.