Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make check_fortran_type return false for inhomogeneous arrays #4

Merged
merged 1 commit into from
Aug 25, 2018

Conversation

sostock
Copy link
Contributor

@sostock sostock commented Aug 22, 2018

Right now, check_fortran_type(x::Array) checks the first element of x instead of its eltype. Therefore, it will return true for, e.g., Integer[Int32(1), BigInt(5)], since Int32 is a bitstype, but serializing the array will fail. This PR makes check_fortran_type return false in these cases.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.192% when pulling b6e9048 on sostock:sostock/inhom into f15021b on traktofon:master.

@codecov-io
Copy link

codecov-io commented Aug 22, 2018

Codecov Report

Merging #4 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
+ Coverage   92.91%   92.93%   +0.02%     
==========================================
  Files           9        9              
  Lines         268      269       +1     
==========================================
+ Hits          249      250       +1     
  Misses         19       19
Impacted Files Coverage Δ
src/write.jl 94.73% <100%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f15021b...b6e9048. Read the comment docs.

@traktofon traktofon merged commit 0d58fcd into traktofon:master Aug 25, 2018
@traktofon
Copy link
Owner

Thanks, that makes sense.

@sostock sostock deleted the sostock/inhom branch August 25, 2018 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants