Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow passing a custom registry to be used instead of using the default one #153

Merged
merged 9 commits into from Feb 22, 2023
Merged

feat: Allow passing a custom registry to be used instead of using the default one #153

merged 9 commits into from Feb 22, 2023

Commits on Feb 22, 2023

  1. ✨ Allow passing a custom registry to be used instead of using the def… 

    …ault one
    @tiangolo @trallnag
    tiangolo authored and trallnag committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    fdf0ab7 View commit details
    Browse the repository at this point in the history

  2. ♻️ Pass the custom registry down to all the places that need it

    @tiangolo @trallnag
    tiangolo authored and trallnag committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    0e7e5cb View commit details
    Browse the repository at this point in the history

  3. ✅ Add tests for multiple apps with custom registries

    @tiangolo @trallnag
    tiangolo authored and trallnag committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    e6376ff View commit details
    Browse the repository at this point in the history

  4. ✅ Test Prometheus doesn't break with other middleware

    @tiangolo @trallnag
    tiangolo authored and trallnag committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    57efb63 View commit details
    Browse the repository at this point in the history

  5. ♻️ Create metrics only if they don't already exist in registry, as St… 

    …arlette might re-instantiate middleware classes
    @tiangolo @trallnag
    tiangolo authored and trallnag committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    f30b10f View commit details
    Browse the repository at this point in the history

  6. ✅ Add tests for custom registry and default registry

    @tiangolo @trallnag
    tiangolo authored and trallnag committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    5d58e47 View commit details
    Browse the repository at this point in the history

  7. ♻️ Wrap adding a new metric in a try block to prevent errors when add… 

    …ing new middlewares
    @tiangolo @trallnag
    tiangolo authored and trallnag committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    93eeeb0 View commit details
    Browse the repository at this point in the history

  8. chore: Fix rebase

    @trallnag
    trallnag committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    597c678 View commit details
    Browse the repository at this point in the history

  9. chore: Update CHANGELOG.md

    @trallnag
    trallnag committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    4d04ef9 View commit details
    Browse the repository at this point in the history