Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Move inclusion of content in info object behind feature flag #238

Merged
merged 7 commits into from Mar 20, 2023

Conversation

trallnag
Copy link
Owner

Fixes issue #234.

Related to pull request #233.

@codecov
Copy link

codecov bot commented Mar 19, 2023

Codecov Report

Merging #238 (0449e8d) into master (e4b9d84) will increase coverage by 0.10%.
The diff coverage is 100.00%.

❗ Current head 0449e8d differs from pull request most recent head 31d2252. Consider uploading reports for the commit 31d2252 to get more accurate results

@@            Coverage Diff             @@
##           master     #238      +/-   ##
==========================================
+ Coverage   95.58%   95.68%   +0.10%     
==========================================
  Files           5        5              
  Lines         340      348       +8     
==========================================
+ Hits          325      333       +8     
  Misses         15       15              
Impacted Files Coverage Δ
...ometheus_fastapi_instrumentator/instrumentation.py 97.14% <100.00%> (+0.04%) ⬆️
...rc/prometheus_fastapi_instrumentator/middleware.py 97.91% <100.00%> (+0.16%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@trallnag trallnag self-assigned this Mar 19, 2023
@trallnag trallnag merged commit d4db652 into master Mar 20, 2023
5 checks passed
@trallnag trallnag deleted the bbeattie-phxlabs-patch-2 branch March 20, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Large content in info response impacts performance a lot
2 participants