Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide status callbacks. #39

Merged
merged 5 commits into from
Sep 26, 2018
Merged

Conversation

petehouston
Copy link
Contributor

This includes following updates:

  • Callbacks for AbstractWorker on success (::onSucceeded()) and on failure (::onFailed()).
  • Query for error if there is, so the implemented workers, inherited from AbstractWorker, can catch error exception to handle.

@codecov
Copy link

codecov bot commented Sep 26, 2018

Codecov Report

Merging #39 into master will decrease coverage by 0.65%.
The diff coverage is 77.77%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #39      +/-   ##
============================================
- Coverage     94.99%   94.33%   -0.66%     
- Complexity      132      137       +5     
============================================
  Files            18       18              
  Lines           539      547       +8     
============================================
+ Hits            512      516       +4     
- Misses           27       31       +4
Impacted Files Coverage Δ Complexity Δ
Service/Worker/AbstractWorker.php 80% <77.77%> (-20%) 10 <4> (+5)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06bf3ca...8b83f7d. Read the comment docs.

Copy link
Owner

@trandangtri trandangtri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR, but please take a look at my feedbacks :)

Service/Worker/AbstractWorker.php Outdated Show resolved Hide resolved
@trandangtri trandangtri merged commit a08f104 into trandangtri:master Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants