Added code examples for Target Data section, showing inheritance and general usage #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explained how to subclass, how to get values from it(including casting), and how to use it with making a target data handle.
YawLighthouse
changed the title
tranek
requested changes
Feb 19, 2023
README.md
Outdated
| UFUNCTION(BlueprintPure) | ||
| FName GetCoolNameFromTargetData(const FGameplayAbilityTargetDataHandle& Handle, const int Index) | ||
| { | ||
| FGameplayAbilityTargetData* data = Handle.Data[Index].Get(); |
There was a problem hiding this comment.
This should check to make sure that Index is within the Handle.Data array bounds.
There was a problem hiding this comment.
Rename data to something else with a capital letter first to follow Unreal style guide like MyData.
1. Added valid checked index 2. Fixed naming convention
tranek
approved these changes
Feb 20, 2023
|
Thanks for adding this example! |
sentyaanko
added a commit
to sentyaanko/GASDocumentation
that referenced
this pull request
Feb 24, 2023
fixed type checking error. fixed typo. added language identifier in fenced code block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue associated: #75
This is to add some sort of examples for target data on how to:
FGameplayAbilityTargetDataFGameplayAbilityTargetDataHandlethat uses this typeFGameplayAbilityTargetDataFGameplayAbilityTargetData