[FIX] Attribute initialisation now gets properly initialised in server and client

[vorixo]

I have some non replicated attributes I'd like to initialise in both, Authority and Autonomous Proxy.

For that I am adding an initializer gameplay effect in the character in PossessedBy (auth) and OnRepPlayerState (aut/sim-proxy).

Well turns out that GASDocumentation ASC lives in the PS, and when I am adding the effect in OnRep_PlayerState, my attributes dont get initialised in the autonomous proxy, but the simulated proxies... i could diagnose a bit, and it seems that even if the character is autonomous proxy in onrep_playerstate, the PS is simulated proxy... so I effectively dont have a way to init non replicated Attributes in the Autonomous Proxy through the offered original method.

TODO: Address this in the documentation since I find it pretty relevant for ASCs that live in the PS.

[tranek]

I see what your issue is, however it is specific to your game - having non-replicated attributes. I won't be including this change in GASDocumentation's code.

Reading the modifiers out of a GameplayEffect feels weird. I'd probably recommend making a TMap<FGameplayAttribute, float> on the AvatarActor's class and iterating through the pairs instead of using GEs.

[vorixo]

Hey Dan, it's not really a project specific thing.

It's about fast client initialization even with replicated attributes.

If you want to consume the attribute value right after initialisation in the client (for prediction reasons) you won't be able to do it with your method, because as I pointed out above FActiveGameplayEffectHandle ActiveGEHandle = AbilitySystemComponent->ApplyGameplayEffectSpecToTarget(*NewHandle.Data.Get(), AbilitySystemComponent.Get()); will do nothing in the client.

If you don't want to benefit from client initialization. I recommend wrapping that initialisation code with a HasAuthority and remove the "can run in server and client" comment.

[tranek]

If you want to consume the attribute value right after initialisation in the client (for prediction reasons) you won't be able to do it with your method, because as I pointed out above FActiveGameplayEffectHandle ActiveGEHandle = AbilitySystemComponent->ApplyGameplayEffectSpecToTarget(*NewHandle.Data.Get(), AbilitySystemComponent.Get()); will do nothing in the client.

Without a valid prediction key, this will do nothing on the client. That is correct and the call to InitializeAttributes() in AGDHeroCharacter::OnRep_PlayerState() can be removed as it's not doing anything.

It's about fast client initialization even with replicated attributes.
If you want to consume the attribute value right after initialisation in the client (for prediction reasons)

For GASDocumentation, the server initializes the attributes in AGDHeroCharacter::PossessedBy(). If the attributes aren't already initialized in the PlayerState replication, then they will be immediately after. I don't know the order here and I'm guessing it happens in the same frame. There won't be any time to predict anything before the attributes are initialized from the server.

[vorixo]

Without a valid prediction key, this will do nothing on the client. That is correct and the call to InitializeAttributes() in AGDHeroCharacter::OnRep_PlayerState() can be removed as it's not doing anything.

Correct, and since this can lead to confusion I think it's better to make it more explicit, I'll try to work towards a more convenient solution given the use case presented here.

For GASDocumentation, the server initializes the attributes in AGDHeroCharacter::PossessedBy(). If the attributes aren't already initialized in the PlayerState replication, then they will be immediately after. I don't know the order here and I'm guessing it happens in the same frame. There won't be any time to predict anything before the attributes are initialized from the server.

I mean... given that abilities can only be granted in the server... But if you consume an attribute in the client at the begining of the game, on a very high ping scenario for any custom prediction action, you'll have issues......... Right, yeah this is very much game dependent, and an extreme edge case, hahaha.

Although it should be stipulated that this initialisation is server only, at least at a conceptual level. I'll work towards that and when I'll have a solution I'll PR it.

[alirezaka80]

hi I make own ability system component and Initialize with PossessedBy and OnRep_PlayerState but when use GiveAbility function
ABILITY_LOG(Error, TEXT("GiveAbility called on ability %s on the client, not allowed!"), *Spec.Ability->GetName()) i have this log and because of IsOwnerActorAuthoritative is true how too fix it?