Skip to content
This repository has been archived by the owner on May 23, 2022. It is now read-only.

Check if syslog or rsyslog is installed before restart logging #3

Closed
wants to merge 6 commits into from

Conversation

Aguay-val
Copy link

I improved the postinst file to consider if the server has syslog or rsyslog installed.

That way the postinst script will restart the right logging system.

@d-cardon
Copy link
Contributor

Hi Aguay-val,

thanks for your interest in WAPT and your contribution. Looking at your pull request, I have a few recommendation:

  • I don't think that python-apt module is a hard dependency on a minimal Debian installation. I think in some case it will just fail
  • when you have commits that fix a typo in the last commit, then you can "squash" them so that they just become one single commit. You can take a look at https://stackoverflow.com/questions/5189560/squash-my-last-x-commits-together-using-git for hints on how to do that.
  • as there is a now a Enterprise version with different licensing from the Community Edition, there is a needed to have a contributor license agreement in order to accept pull requests (otherwise the code would be only GPLv3 and couldn't be relicensed and reused for WAPT Enterprise version).

Cheers,

Denis

Valentin Baraise added 3 commits March 29, 2018 13:35
commit 06d03b9
Author: Aguay-val <Aguay-val@users.noreply.github.com>
Date:   Thu Mar 15 09:42:48 2018 +0100

    typo. Bad run function. Added extra "t"

commit 629f3e7
Author: Aguay-val <Aguay-val@users.noreply.github.com>
Date:   Thu Mar 15 09:41:43 2018 +0100

    Typo, missing )

commit 6b8a0bf
Author: Aguay-val <Aguay-val@users.noreply.github.com>
Date:   Thu Mar 15 09:36:40 2018 +0100

    Check if syslog or rsyslog is installed before restart logging
@Aguay-val
Copy link
Author

I'm sorry I'm pretty new to submit PRs :)

And because i'm not a developper i'm not familiar yet with those tools !
Anyway, I modified the postinst by using os and subprocess modules which are installed with "python-minimal".

I tried to use squash as suggested !
And i'll send you the contributor license agreement as soon as possible !

Thank you !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants