Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhooks use profile.identifier #10

Merged
merged 2 commits into from Sep 30, 2020

Conversation

michaelfarrell76
Copy link
Member

@michaelfarrell76 michaelfarrell76 commented Sep 29, 2020

Noticed that the examples were all assuming that the servers were looking up by the core identifier. This changes updates the examples to allow for webhooks to respond to arbitrary identifier types.

Take the following workflow:

  1. Data subject submits a DSR with a user
  2. Enricher resolves email -> username
  3. server silo takes in a username to perform an opt out.

In this case the profileId should be the username, not the core identifier/email.

Updated Receiving DSR docs
Updated Upload to our API docs

@michaelfarrell76
Copy link
Member Author

michaelfarrell76 commented Sep 29, 2020

In the current state this profile is embedded in req.body.extras.profile.identifier. I'm thinking we bump the minor version and duplicate the profile in the top level field as req.body.profile.identifier.

@bencmbrook what do you think?

@michaelfarrell76 michaelfarrell76 merged commit eca99a7 into master Sep 30, 2020
@delete-merged-branch delete-merged-branch bot deleted the michaelfarrell76/updates-to-use-profile branch September 30, 2020 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants