Skip to content

Commit

Permalink
Fix windows test failures (#311)
Browse files Browse the repository at this point in the history
* fix windows test failure
  • Loading branch information
Almenon committed Apr 13, 2024
1 parent 2ac219b commit cfa8c72
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 8 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
########### Custom ###########
##############################
.vscode/
*.code-workspace
build
test_artifacts

Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
VERSION=1.17.8
VERSION=1.17.9
PATH_BUILD=build/
FILE_COMMAND=terragrunt-atlantis-config
FILE_ARCH=$(shell go env GOOS)_$(shell go env GOARCH)
Expand Down
10 changes: 5 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ Then, make sure `terragrunt-atlantis-config` is present on your Atlantis server.

```hcl
variable "terragrunt_atlantis_config_version" {
default = "1.17.8"
default = "1.17.9"
}
build {
Expand Down Expand Up @@ -191,11 +191,11 @@ You can install this tool locally to checkout what kinds of config it will gener
Recommended: Install any version via go install:

```bash
go install github.com/transcend-io/terragrunt-atlantis-config@v1.17.8
go install github.com/transcend-io/terragrunt-atlantis-config@v1.17.9
```

This module officially supports golang versions v1.13, v1.14, v1.15, and v1.16, tested on CircleCI with each build
This module also officially supports both Windows and Nix-based file formats, tested on CircleCI with each build
This module officially supports golang version v1.21, tested on Github with each build.
This module also officially supports both Windows and Nix-based file formats, tested on Github with each build.

Usage Examples (see below sections for all options):

Expand All @@ -216,7 +216,7 @@ Finally, check the log output (or your output file) for the YAML.

To test any changes you've made, run `make gotestsum` (or `make test` for standard golang testing).

Once all your changes are passing and your PR is reviewed, a merge into `master` will trigger a Github Actions job to build the new binary, test it, and deploy it's artifacts to Github Releases along with checksums.
When your PR is merged and a tag is created, a Github Actions job to build the new binary, test it, and deploy it's artifacts to Github Releases along with checksums.

You can then open a PR on our homebrew tap similar to https://github.com/transcend-io/homebrew-tap/pull/4, and as soon as that merges your code will be released. Homebrew is not updated for every release, as Github is the primary artifact store.

Expand Down
2 changes: 1 addition & 1 deletion cmd/generate.go
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ func getDependencies(path string, terragruntOptions *options.TerragruntOptions)
}

// Check if the path begins with a drive letter, denoting Windows
isWindowsPath, err := regexp.MatchString(`^[A-Z]:`, parsedSource)
isWindowsPath, err := regexp.MatchString(`^[A-Za-z]:`, parsedSource)
if err != nil {
return nil, err
}
Expand Down
2 changes: 1 addition & 1 deletion main.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import "github.com/transcend-io/terragrunt-atlantis-config/cmd"
// This variable is set at build time using -ldflags parameters.
// But we still set a default here for those using plain `go get` downloads
// For more info, see: http://stackoverflow.com/a/11355611/483528
var VERSION string = "1.17.8"
var VERSION string = "1.17.9"

func main() {
cmd.Execute(VERSION)
Expand Down

0 comments on commit cfa8c72

Please sign in to comment.