Fix issue with parsing for a cascading dependencies case, Fix Duplicated dependencies, Handle Relative/Absolute Paths more gracefully #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Improvement: In order to fix the issue with cascading dependencies this add extra checks to handle both the case that a dependency uses an absolute path or a relative one. - Improvement: Also converts relative dependencies to absolute to avoid duplicates and re-converts the dependencies to relative before the configuration file is generated. - Fix: Creates new terragrunt options with the dependency path in order to be able to parse successfully the cascading dependencies.
|
It seems that the improvement of handling duplicated dependencies has been also solved to #113 |
|
@dmattia can you please take a look, please 😄 ? |
dmattia
approved these changes
Feb 4, 2021
|
Looks great @angeloskaltsikis! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related Github Issues
Description
Improvement: In order to fix the issue with cascading dependencies this adds extra checks to handle both the case that a dependency uses an absolute path or a relative one.
Improvement: Also converts relative dependencies to absolute to avoid duplicates and re-converts the dependencies to a relative before the configuration file is generated.
Fix issue with parsing for a cascading dependencies case
Creates new terragrunt options with the dependency path in order to be able to parse successfully the cascading dependencies.
Security Implications
System Availability