Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parallel projects creation #141

Merged
merged 1 commit into from May 20, 2021

Conversation

fbad
Copy link
Contributor

@fbad fbad commented May 20, 2021

Pull Request

Related Github Issues

  • [none]

Description

This PR fixes parallel projects creation:

  • Additional --num-executors parameter to customize the parallelism of projects creation.
  • Introduce synchronized map for dependencies cache.
  • Introduce singleflight for duplicate function call suppression to getDependencies.
  • Introduce testify to fix tests which now may find unordered projects in resulting atlantis configuration.

Security Implications

  • [none]

System Availability

  • [none]

@fbad
Copy link
Contributor Author

fbad commented May 20, 2021

Hi @dmattia could you please have a look at this?

@dmattia dmattia self-requested a review May 20, 2021 16:02
Copy link
Member

@dmattia dmattia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks excellent!

@dmattia dmattia merged commit 3c78a99 into transcend-io:master May 20, 2021
@dmattia
Copy link
Member

dmattia commented May 20, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants