MB-10464 Add reasons for why local docker setup isn't supported anymore #89
Conversation
felipe-lee
requested review from
ahobson,
gidjin,
NamibiaTorres,
duncan-truss,
pearl-truss and
ronaktruss
README.md
Outdated
| @@ -182,8 +182,17 @@ entirely at a future date. | |||
|
|
|||
| #### Alternative Setup: Docker | |||
|
|
|||
| It is also possible to run load tests from within a Docker container, eliminating the need to set up a valid python | |||
| environment. This requires Docker and `docker-compose` to be installed on your machine. Get them here: | |||
| It might be possible to run load tests from within a docker container, though given recent updates this seems to not be | |||
There was a problem hiding this comment.
Nit: maybe consider dropping "recent" since some time might pass before this is looked at again. Also, it might be worth linking to the PRs that introduced the breaking changes here
I'm in favor of this since it's not working I don't think we need instructions for it anymore but it would be nice to have a reference to the reasons |
|
I'm also in favor of removing the instructions and indicating the reasons that we don't support it. If we do this we should also remove some of the code/files that are specific for this functionality such as |
|
Sounds good, I can make those updates, thanks for the feedback! |
…r-is-no-longer-supported-locally
Add a more detailed reason for removing `asdf` setup. Add links to PRs that removed `asdf` and `docker` setups.
|
@pearl-truss @ronaktruss , I deleted the local docker setup entirely now, added the PR links to the README, and modified the details a little. I'd mentioned in my description that maybe we should just remove everything from the README regarding local docker |
felipe-lee
deleted the
MB-10464-update-docs-to-indicate-why-docker-is-no-longer-supported-locally
branch
Description
In a previous PR (#74) the local docker setup broke and in a later PR (#78) the instructions were updated indicating the local docker setup wouldn't be supported anymore, but didn't give reasoning. This PR adds some reasons for the change so that future maintainers can have some context.
Reviewer Notes
Given that the local docker setup is broken, would it maybe be better to delete the instructions and have my git commit list the reasons?
Setup
Easiest way to read the formatted README would probably be to look at the README on this branch in github.
Code Review Verification Steps
References