Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten the route for shipment info to remove the queue name #1022

Merged
merged 4 commits into from Sep 21, 2018

Conversation

chrisgilmerproj
Copy link
Contributor

@chrisgilmerproj chrisgilmerproj commented Sep 20, 2018

Description

This has bugged me for a while. The way to get to a shipment should always be independent of the queue its associated with. This will make more sense when we also have the shipments/:shipmentId/documents and shipments/:shipmentId/documents/:moveDocumentId routes.

Code Review Verification Steps

  • End to end tests pass (make e2e_test).
  • Request review from a member of a different team.

@chrisgilmerproj
Copy link
Contributor Author

I think e2e tests would work if the branch was built on this: https://github.com/transcom/mymove/pull/1019/files

@jim jim self-requested a review September 21, 2018 18:23
Copy link
Contributor

@jim jim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrisgilmerproj Code looks good.

I believe that originally there were some next/forward controls to move within a queue on the shipment page, which was probably the original impetus for those URLs.

We don't have those, though, so I say go for this simplification.

@chrisgilmerproj chrisgilmerproj merged commit 1e81f7f into master Sep 21, 2018
@chrisgilmerproj chrisgilmerproj deleted the cg_fix_shipment_route branch September 21, 2018 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants