Include a better failure message if the app container fails unexpectedly #1503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dly. Include a commented out instruction on how to debug unexpected failures
chrisgilmerproj
deleted the
cg_better_error_message_e2e_unexpected_failure
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Also include a commented out instruction on how to debug unexpected failures
Reviewer Notes
Could the error message be better?
Setup
Remove an environment variable from https://github.com/transcom/mymove/blob/master/bin/run-e2e-test-docker#L37-L63 and run this:
You should see the failure message appear.
Code Review Verification Steps