Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Go to 1.11.5 #1695

Merged
merged 7 commits into from Feb 4, 2019
Merged

Upgrade Go to 1.11.5 #1695

merged 7 commits into from Feb 4, 2019

Conversation

akostibas
Copy link
Contributor

@akostibas akostibas commented Feb 2, 2019 •
edited

This PR upgrades Go in our project to 1.11.5. This will include a security fix added in the .5 patch release.

Other changes in this PR:

  • Running the gosec pre-commit hook in serial mode.
    • This is because the CircleCI containers were seemingly running out of memory (see how it failed), despite having some 18GB free--as seen by SSH'ing into the instance. Maybe there are other CircleCI limits imposed that I am unaware of.
    • This behavior wasn't happening on my local machine.
    • Changing to serial mode doesn't seem to appreciably add time to the pre-test run, as seen comparing this serial run against a previous parallel run.
    • It's possible we could do something to increase the resource limits of CircleCI to overcome this without the serial change. @chrisgilmerproj: I'm curious if you have thoughts.
  • ShellCheck was griping about external sources in the psql scripts. It's unclear why this started up in my PR, as I didn't change anything around pre-commit, but it looks like it should have always been failing based on how I understand the ShellCheck pre-commit script.

Before landing, I will announce to #eng that everyone needs to upgrade their Go version.

@akostibas
use the Truss docker image with go 1.11.5
ef7cd75
@akostibas
disabling shellcheck errors for external sources
4e95aea 
we were getting messages like:
In bin/psql-dev line 5:
. "$(dirname "$0")"/psql
  ^--------------------^ SC1091: Not following: bin/psql was not specified as input (see shellcheck -x).
@akostibas
update to go 1.11.5
ee52781
@akostibas
running gosec in serial to keep circle from exploding
6d2382b
chrisgilmerproj
chrisgilmerproj reviewed Feb 4, 2019
View reviewed changes
bin/psql-dev Outdated Show resolved Hide resolved
@chrisgilmerproj
Copy link
Contributor

We can certainly increase the resource_class for these tests but I'd like to see what happens if we use the change from @pjdufour-truss 's PR.

chrisgilmerproj
chrisgilmerproj approved these changes Feb 4, 2019
View reviewed changes
Copy link
Contributor

@chrisgilmerproj chrisgilmerproj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@akostibas akostibas merged commit d033bc8 into master Feb 4, 2019
@akostibas akostibas deleted the ak-upgrade-go branch February 4, 2019 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisgilmerproj chrisgilmerproj chrisgilmerproj approved these changes

@tinyels tinyels Awaiting requested review from tinyels

@stangah stangah Awaiting requested review from stangah

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@akostibas @chrisgilmerproj