New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Go to 1.11.5 #1695

Merged
merged 7 commits into from Feb 4, 2019

Conversation

2 participants
@akostibas
Copy link
Contributor

akostibas commented Feb 2, 2019

This PR upgrades Go in our project to 1.11.5. This will include a security fix added in the .5 patch release.

Other changes in this PR:

  • Running the gosec pre-commit hook in serial mode.
    • This is because the CircleCI containers were seemingly running out of memory (see how it failed), despite having some 18GB free--as seen by SSH'ing into the instance. Maybe there are other CircleCI limits imposed that I am unaware of.
    • This behavior wasn't happening on my local machine.
    • Changing to serial mode doesn't seem to appreciably add time to the pre-test run, as seen comparing this serial run against a previous parallel run.
    • It's possible we could do something to increase the resource limits of CircleCI to overcome this without the serial change. @chrisgilmerproj: I'm curious if you have thoughts.
  • ShellCheck was griping about external sources in the psql scripts. It's unclear why this started up in my PR, as I didn't change anything around pre-commit, but it looks like it should have always been failing based on how I understand the ShellCheck pre-commit script.

Before landing, I will announce to #eng that everyone needs to upgrade their Go version.

akostibas added some commits Jan 31, 2019

disabling shellcheck errors for external sources
we were getting messages like:
In bin/psql-dev line 5:
. "$(dirname "$0")"/psql
  ^--------------------^ SC1091: Not following: bin/psql was not specified as input (see shellcheck -x).

@akostibas akostibas requested review from chrisgilmerproj , tinyels and stangah Feb 2, 2019

Show resolved Hide resolved .pre-commit-config.yaml Outdated
Show resolved Hide resolved bin/psql-dev Outdated
@chrisgilmerproj

This comment has been minimized.

Copy link
Contributor

chrisgilmerproj commented Feb 4, 2019

We can certainly increase the resource_class for these tests but I'd like to see what happens if we use the change from @pjdufour-truss 's PR.

akostibas added some commits Feb 4, 2019

@chrisgilmerproj
Copy link
Contributor

chrisgilmerproj left a comment

🚀

@akostibas akostibas merged commit d033bc8 into master Feb 4, 2019

14 checks passed

ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_mymove Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_office Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_tsp Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details

@akostibas akostibas deleted the ak-upgrade-go branch Feb 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment