Upgrade dep version

[kahlouie]

Description

Upgrade dep to 0.5.1

Reviewer Notes

It appears that dep now adds a /.vendor-new file. To keep in line with how we've ignored the vendor folder prior, I've done the same here. I'm unclear if I should also be removing the original /vendor folder from our .gitignore.

Setup

n/a

Code Review Verification Steps

• Request review from a member of a different team.
• Have the Pivotal acceptance criteria been met for this change?

References

• https://www.pivotaltracker.com/story/show/164713350

[chrisgilmerproj]

This is going to require a change here I think: https://github.com/trussworks/circleci-docker-primary/blob/master/Dockerfile#L51-L56

[kahlouie]

Thanks @chrisgilmerproj I'll get a pr up for that and block this one on that.

[reggieriser]

I tested this out locally going back and forth between old and new dep. The pre-commit hook acted as expected. With 0.5.1, I did a make clean, then built the project, then ran server tests. Seemed fine.

For what it's worth, I never saw a .vendor-new file appear. I do recall in the past seeing a vendor.orig (I think?) every now and then. Don't know that there's any harm in putting it in .gitignore though.

There's a dep FAQ about committing the vendor folder. I would keep it ignored like we do now.

I'm going to go ahead and approve this one so you're ready with it when the blocking Dockerfile PR is approved/merged.

[codecov]

Codecov Report

Merging #1918 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1918   +/-   ##
=======================================
  Coverage   50.81%   50.81%           
=======================================
  Files         446      446           
  Lines       19411    19411           
  Branches     1691     1691           
=======================================
  Hits         9863     9863           
  Misses       8683     8683           
  Partials      865      865

[chrisgilmerproj]

🚀