New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare Address Field for Robust Accessorial use #1925
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@garrettqmartin8 and I say 🚢
might want to mention in pivotal that there's an address3 field since that's not mentioned in the story...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. 🚢
…5-add-address-field
…5-add-address-field
Codecov Report
@@ Coverage Diff @@
## master #1925 +/- ##
==========================================
+ Coverage 61.25% 61.25% +<.01%
==========================================
Files 192 192
Lines 12401 12409 +8
==========================================
+ Hits 7596 7601 +5
- Misses 3913 3916 +3
Partials 892 892 |
Description
There is a forthcoming need for a general address field to be used in office and TSP apps. This already exists, it turns out, but it needs some tuning up.
I expect that when this field is used in robust accessorials, it will need some slight style modifications, but we can deal with that at the time. For now we just need a flexible address component.
Code Review Verification Steps
References