Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare Address Field for Robust Accessorial use #1925

Merged
merged 16 commits into from Apr 24, 2019

Conversation

Igarfinkle
Copy link
Contributor

@Igarfinkle Igarfinkle commented Mar 27, 2019

Description

There is a forthcoming need for a general address field to be used in office and TSP apps. This already exists, it turns out, but it needs some tuning up.

I expect that when this field is used in robust accessorials, it will need some slight style modifications, but we can deal with that at the time. For now we just need a flexible address component.

Code Review Verification Steps

  • Request review from a member of a different team.
  • Have the Pivotal acceptance criteria been met for this change?

References

@Igarfinkle Igarfinkle added the ttv label Mar 27, 2019
@Igarfinkle Igarfinkle marked this pull request as ready for review March 29, 2019 22:59
Copy link
Contributor

@lynzt lynzt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@garrettqmartin8 and I say 🚢

might want to mention in pivotal that there's an address3 field since that's not mentioned in the story...

Copy link
Contributor

@donaldthai donaldthai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 🚢

@codecov
Copy link

codecov bot commented Apr 12, 2019

Codecov Report

Merging #1925 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1925      +/-   ##
==========================================
+ Coverage   61.25%   61.25%   +<.01%     
==========================================
  Files         192      192              
  Lines       12401    12409       +8     
==========================================
+ Hits         7596     7601       +5     
- Misses       3913     3916       +3     
  Partials      892      892

@Igarfinkle
Copy link
Contributor Author

image

Here's the component as it exists right now. We can do a full design review over Zoom if we like.

@Igarfinkle Igarfinkle merged commit bd4a540 into master Apr 24, 2019
@Igarfinkle Igarfinkle deleted the ig-162734025-add-address-field branch May 7, 2019 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants