New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Admin Subdomain Middleware #1968
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1968 +/- ##
=========================================
- Coverage 60.63% 50.8% -9.84%
=========================================
Files 193 446 +253
Lines 12288 19434 +7146
Branches 0 1695 +1695
=========================================
+ Hits 7451 9873 +2422
- Misses 3958 8694 +4736
+ Partials 879 867 -12
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚢 it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One fix and then this is ready to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖
Description
Add the middleware to support the admin subdomain
Reviewer Notes
I feel a little bit like I'm duct taping here. Is there anything we can do to improve this a little while we're in here?
Code Review Verification Steps
References