Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove top level mocks directory #2271

Merged
merged 1 commit into from Jun 13, 2019
Merged

Remove top level mocks directory #2271

merged 1 commit into from Jun 13, 2019

Conversation

mkrump
Copy link
Contributor

@mkrump mkrump commented Jun 13, 2019

Description

Remove top level mock directory and replace manually generated mocks with autogenerated mocks. The top level mocks directory should have been removed in #2215. It looks a couple long running PRs accidentally brought it back.

Setup

rm .mocks_generate.stamp
make server_test

Copy link
Contributor

@chrisgilmerproj chrisgilmerproj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 - Thank you for fixing this!

@mkrump mkrump merged commit 6aee3f7 into master Jun 13, 2019
@mkrump mkrump deleted the remove-mock-dir branch June 13, 2019 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants