Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add duty station search improvements: 167501188 #2760
Make searching for a duty station more flexible... allow "fuzzy" matching.
Use trigram matching when letting a SM or an Office user search for duty stations. Calculate the similarity between the "search query" and the duty stations and return the top 7 results.
Alternate spellings/abbrs we want to catch are in the pivotal story linked as a spreadsheet.
Add any steps or code to run in this section to help others prepare to run your code:
Log into SM or Office app and do a duty station search using "alternate" duty station names... or try fuzzy searching for things:
Code Review Verification Steps
@@ Coverage Diff @@ ## master #2760 +/- ## ======================================== + Coverage 57.6% 57.6% +0.1% ======================================== Files 278 276 -2 Lines 12567 12550 -17 ======================================== - Hits 7233 7226 -7 + Misses 4586 4578 -8 + Partials 748 746 -2
Ryan-Koch left a comment
This looks really great! I left a minor comment about the query, but otherwise this seems to do what it's supposed to. I think after the load testing that was mentioned in another comment it's good to go.