Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reasons why to not use uuid_generate_v4 in migrations #2923

Merged
merged 3 commits into from Nov 5, 2019

Conversation

@gidjin
Copy link
Contributor

gidjin commented Nov 4, 2019

Description

I wanted to note down why we do not generate uuids in a migration but before to help future people understand the choice better.

References

@gidjin gidjin requested review from chrisgilmerproj, kimallen and tinyels Nov 4, 2019
@gidjin gidjin added the A-Team label Nov 4, 2019
Copy link
Contributor

chrisgilmerproj left a comment

Can you find instances of uuid_generate_v4() in the docs/ folder and either fix them or link to this comment wherever you see them? I am seeing stuff in a few places around tspp and tariff data that should be fixed or annotated.

@jacquelineIO

This comment has been minimized.

Copy link
Contributor

jacquelineIO commented Nov 4, 2019

Can you find instances of uuid_generate_v4() in the docs/ folder and either fix them or link to this comment wherever you see them? I am seeing stuff in a few places around tspp and tariff data that should be fixed or annotated.

@chrisgilmerproj that's not in the scope of this story. Plus that would have to involve developing new instructions how to do those imports. I would request that a new story is written to handle that. Plus I see a bunch of migrations using it and how do you want to handle that?

@tinyels
tinyels approved these changes Nov 4, 2019
Copy link
Contributor

tinyels left a comment

LGTM

@chrisgilmerproj

This comment has been minimized.

Copy link
Contributor

chrisgilmerproj commented Nov 4, 2019

@chrisgilmerproj that's not in the scope of this story. Plus that would have to involve developing new instructions how to do those imports. I would request that a new story is written to handle that. Plus I see a bunch of migrations using it and how do you want to handle that?

Maybe I was confusing. I'm asking for documentation fixes only. Links primarily but if you can fix something that would be nice.

@chrisgilmerproj

This comment has been minimized.

Copy link
Contributor

chrisgilmerproj commented Nov 4, 2019

Also, @jacquelineIO - since I forgot to add this. Previous migrations aren't ever run again in Production so we decided to leave them alone. We can retroactively modify all of them but it would only affect development and was considered not worth it at the time.

@gidjin gidjin requested a review from chrisgilmerproj Nov 5, 2019
@gidjin

This comment has been minimized.

Copy link
Contributor Author

gidjin commented Nov 5, 2019

@chrisgilmerproj Adding links seems reasonable. I think the two docs may have been okay since they are for generating sql to import into the database, which I think is typically exported. But just in case I made some updates to hopefully clarify things. Please review it again and let me know if it's good to go.

Copy link
Contributor

chrisgilmerproj left a comment

🚀

@gidjin gidjin merged commit 1d8c9f5 into master Nov 5, 2019
15 checks passed
15 checks passed
ci/circleci: acceptance_tests_experimental Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_local Your tests passed on CircleCI!
Details
ci/circleci: acceptance_tests_staging Your tests passed on CircleCI!
Details
ci/circleci: build_app Your tests passed on CircleCI!
Details
ci/circleci: build_migrations Your tests passed on CircleCI!
Details
ci/circleci: build_storybook_app Your tests passed on CircleCI!
Details
ci/circleci: build_tasks Your tests passed on CircleCI!
Details
ci/circleci: build_tools Your tests passed on CircleCI!
Details
ci/circleci: check_generated_code Your tests passed on CircleCI!
Details
ci/circleci: client_test Your tests passed on CircleCI!
Details
ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_golang Your tests passed on CircleCI!
Details
ci/circleci: pre_deps_yarn Your tests passed on CircleCI!
Details
ci/circleci: pre_test Your tests passed on CircleCI!
Details
ci/circleci: server_test Your tests passed on CircleCI!
Details
@gidjin gidjin deleted the gdjn_169549297_add_reasons_for_generating_uuids branch Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.