New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reasons why to not use uuid_generate_v4 in migrations #2923
Add reasons why to not use uuid_generate_v4 in migrations #2923
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you find instances of uuid_generate_v4()
in the docs/
folder and either fix them or link to this comment wherever you see them? I am seeing stuff in a few places around tspp and tariff data that should be fixed or annotated.
@chrisgilmerproj that's not in the scope of this story. Plus that would have to involve developing new instructions how to do those imports. I would request that a new story is written to handle that. Plus I see a bunch of migrations using it and how do you want to handle that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Maybe I was confusing. I'm asking for documentation fixes only. Links primarily but if you can fix something that would be nice. |
Also, @jacquelineIO - since I forgot to add this. Previous migrations aren't ever run again in Production so we decided to leave them alone. We can retroactively modify all of them but it would only affect development and was considered not worth it at the time. |
…reasons_for_generating_uuids
@chrisgilmerproj Adding links seems reasonable. I think the two docs may have been okay since they are for generating sql to import into the database, which I think is typically exported. But just in case I made some updates to hopefully clarify things. Please review it again and let me know if it's good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Description
I wanted to note down why we do not generate uuids in a migration but before to help future people understand the choice better.
References