Update docs to reflect new error wrap pattern #3189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gidjin
requested review from
jim,
chrisgilmerproj,
chrisrcoles,
jacquelineIO,
kimallen,
rdhariwal,
reggieriser and
tinyels
tinyels
reviewed
Dec 12, 2019
|
I agree with @tinyels - let's have a before and after section that shows folks how we used to do it. Folks are still going to come across the old pattern and will want to know how to update. |
|
That's a good idea, I'll add some details to clarify how to migrate |
As the standard just recently changed adding some details about the old way and how to change it to the new recommendation so it can be updated as we go along.
|
@chrisgilmerproj @tinyels I pushed a change to add some details around the previous recommendation to hopefully reduce confusion as people try to follow the new standard. |
…_reflect_new_error_wrap_pattern
gidjin
deleted the
gdjn_update_docs_to_reflect_new_error_wrap_pattern
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As of go 1.13 there is a new suggested pattern for wrapping errors. This PR updates the docs to reflect that.
Code Review Verification Steps
References