Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock test requirements #6

Merged
merged 1 commit into from
Aug 25, 2021
Merged

Lock test requirements #6

merged 1 commit into from
Aug 25, 2021

Conversation

koszti
Copy link
Collaborator

@koszti koszti commented Aug 25, 2021

Problem

Linter is currently failing because unspecified-encoding (W1514) pylint check was introduced very recently.

Proposed changes

Lock test requirements to fix versions and remove not required ones.

Using the automatically the latest version makes the packaged python code not reproducable and better to lock at least the major and minor versions. On the other hand the affected requirements are only test requirements so if we prefer we can leave it as is, pointing always to the latest.

Types of changes

What types of changes does your code introduce to PipelineWise?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Description above provides context of the change
  • I have added tests that prove my fix is effective or that my feature works
  • Unit tests for changes (not needed for documentation changes)
  • CI checks pass with my changes
  • Bumping version in setup.py is an individual PR and not mixed with feature or bugfix PRs
  • Commit message/PR title starts with [AP-NNNN] (if applicable. AP-NNNN = JIRA ID)
  • Branch name starts with AP-NNN (if applicable. AP-NNN = JIRA ID)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions

@koszti koszti merged commit a108bd7 into main Aug 25, 2021
@koszti koszti deleted the lock-deps branch August 25, 2021 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants