-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AP-1011 archive_load_files feature #178
Conversation
e75665d
to
3552f07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please change the multi level archive_load_files.enabled
option to be simply archive_load_files
? Every option in the config.json
is single level and keeping it consistent would make life easier. I added suggestions to the PR above.
Also, can you please document the new archive_load_files
optional parameter in README.md
in the Config settings section?
@koszti Requested changes have been made. In addition, as discussed on Slack, the |
Problem
https://transferwise.atlassian.net/browse/AP-1011
Proposed changes
When enabled, this feature will result in PipelineWise load files being copied to a separate folder for archival.
When used in conjunction with incremental replication, the replication key and its min/max value in each archived file are included in S3 metadata.
Original grooming document (slightly outdated now):
https://docs.google.com/document/d/11UTlmWVJS9aGickmyxpXOUhrv4RTPnm8zip_IqeR2J0/edit?ts=609e4106
(Old WIP PR: #174)
Types of changes
What types of changes does your code introduce to PipelineWise?
Put an
x
in the boxes that applyChecklist
setup.py
is an individual PR and not mixed with feature or bugfix PRs[AP-NNNN]
(if applicable. AP-NNNN = JIRA ID)AP-NNN
(if applicable. AP-NNN = JIRA ID)