fix: Migrate away from synthetic accessors #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The api file helped me spot this :) Signed-off-by: Antal János Monori <antal.monori@transferwise.com> Add API Kotlin binary validator - Add API contract for sequence-layout - Check task now will verify changes in this Signed-off-by: Antal János Monori <antal.monori@transferwise.com> Add a bit more data Signed-off-by: Antal János Monori <antal.monori@transferwise.com> Add release GHA, migrate to maven-publish and remove jcenter Signed-off-by: Antal János Monori <antal.monori@transferwise.com> Add flag required for API 31 Signed-off-by: Antal János Monori <antal.monori@transferwise.com> Re-add proguardFiles Signed-off-by: Antal János Monori <antal.monori@transferwise.com> Inline versions, enable GHA/dependabot and refactor structure - Removed buildSrc and inlined Versions.kt - Switched to Groovy and enabled dependabot.yml - Renamed sequence layout to library - Added build.yml with basic verification step - Bump compile/target SDK to 31 - Removed kotlin-stdlib dependency since that's now redundant from Kotlin 1.4.x (see: https://kotlinlang.org/docs/whatsnew14.html#dependency-on-the-standard-library-added-by-default) - Use gradle bin instead of all - Removed redundant settings from gradle.build like versionName/versionCode and release buildType settings Signed-off-by: Antal János Monori <antal.monori@transferwise.com>
- Replace it with regular findViewById Signed-off-by: Antal János Monori <antal.monori@transferwise.com>
- r8 was complaining about some missing classes when running the sameple app Signed-off-by: Antal János Monori <antal.monori@transferwise.com>
saschoar
approved these changes
Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Remove kotlin synthetic view accessors and
kotlinx-extensionsand replace it with regularfindViewByIdChecklist