Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update build tools #27

Merged
merged 2 commits into from
Nov 24, 2021

Conversation

anthonymonori
Copy link
Contributor

Context

Update build tools to latest stable version

  • Updated to binary-compatibility-validator 0.8.0
  • Updated Gradle wrapper to 7.3
  • Updated to AGP 7.0.3

Checklist

@anthonymonori anthonymonori added the dependencies Pull requests that update a dependency file label Nov 18, 2021
@anthonymonori anthonymonori self-assigned this Nov 18, 2021
@anthonymonori anthonymonori requested a review from a team as a code owner November 18, 2021 20:04
@anthonymonori anthonymonori marked this pull request as draft November 18, 2021 20:25
Comment on lines 52 to 59
public abstract interface class com/transferwise/sequencelayout/SequenceStep$OnStepChangedListener {
public abstract fun onStepChanged ()V
}

public final class com/transferwise/sequencelayout/SequenceStepDot : android/widget/FrameLayout {
public field _$_findViewCache Ljava/util/Map;
public fun <init> (Landroid/content/Context;)V
public fun <init> (Landroid/content/Context;Landroid/util/AttributeSet;)V
public fun <init> (Landroid/content/Context;Landroid/util/AttributeSet;I)V
public fun _$_clearFindViewByIdCache ()V
public fun _$_findCachedViewById (I)Landroid/view/View;
public fun setActivated (Z)V
public final fun setDotBackground$com_transferwise_sequencelayout_null_release (II)V
public fun setEnabled (Z)V
public final fun setPulseColor$com_transferwise_sequencelayout_null_release (I)V
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These internal ones should not have been here in the first place at all, but after we bumped from Kotlin 1.4.x -> 1.6 these got generated incorrectly with 0.5.0 version of the plugin. Now that I have updated to 0.8.0 which includes the fix to this, these are free to remove as none of them are a public API.

See: Kotlin/binary-compatibility-validator#53

@anthonymonori anthonymonori marked this pull request as ready for review November 18, 2021 20:38
- Updated to binary-compatibility-validator 0.8.0
- Updated to Gradle 7.3
- Updated to AGP 7.0.3

Signed-off-by: Antal János Monori <antal.monori@transferwise.com>
…0.8.0

- See: Kotlin/binary-compatibility-validator#53

Signed-off-by: Antal János Monori <antal.monori@transferwise.com>
@anthonymonori anthonymonori merged commit 157bc5d into transferwise:master Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants