Ignore empty strings in KEYVALUEJSON format #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbairak
force-pushed
the
json_empty_strings
branch
from
32bd6de
to
763105f
Compare
| @@ -71,6 +73,8 @@ def _extract(self, parsed, nest=None): | |||
| else: | |||
| key = u"{}..{}..".format(nest, index) | |||
| if isinstance(item, (str, unicode)): | |||
There was a problem hiding this comment.
a small thing here. I know it is not relevant to the current PR but this:
isinstance(value, (str, unicode))
can be like this:
isinstance(value, basestring)
|
Also again on a general note (not related to the PR). Anyway besides those comments everything looks legit to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ollandos spare two minutes to review n' merge this? 😻