Version 2 of GithubMarkdownHandler using an actual yaml parser #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
August 28, 2017 17:10
SofiaMargariti
changed the title
SofiaMargariti
force-pushed
the
yaml_parser
branch
2 times, most recently
from
a0361e5
to
3f0a112
Compare
SofiaMargariti
force-pushed
the
yaml_parser
branch
from
3f0a112
to
f103d86
Compare
diegobz
reviewed
Aug 30, 2017
| - aa8c6113a4236d576f96ba9b0bd4dfa4_tr | ||
| - 76d7c5ccc4301f10b39115b2c1a9ca47_tr | ||
|
|
||
| description: fdba4efe4ab9d38afee4054a7fa06e29_trcustom_vars: |
There was a problem hiding this comment.
@SofiaMargariti looks like we have a missing \n here.
There was a problem hiding this comment.
@diegobz yes, this is known behaviour. The solution I was thinking is to append a new line during compilation in this type of strings, but another way is to lower the end index of this node by one during parsing, so the new line is considered part of the template.
SofiaMargariti
force-pushed
the
yaml_parser
branch
from
bed4ceb
to
e2c9eac
Compare
SofiaMargariti
force-pushed
the
yaml_parser
branch
from
fe0dbb0
to
bfe3d2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://transifex.atlassian.net/browse/TX-8511
Implement yaml parser based on https://github.com/transifex/txc/blob/devel/transifex/resources/formats/yml/yml.py
and use this parser for the frontmatter header of the GFM files.